Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Ninja in Windows CI and explicitly set the VS toolset version. #1906

Merged
merged 5 commits into from
Mar 1, 2024

Conversation

teo-tsirpanis
Copy link
Member

@teo-tsirpanis teo-tsirpanis commented Mar 1, 2024

Use Ninja in Windows CI and explicitly set the VS toolset version.


x-ref TileDB-Inc/TileDB#4759

@teo-tsirpanis
Copy link
Member Author

Nightly builds succeed on Windows.

Some other jobs fail intermittently but all succeed at least once.

@teo-tsirpanis teo-tsirpanis marked this pull request as ready for review March 1, 2024 12:54
@ihnorton ihnorton merged commit 69d4ac7 into dev Mar 1, 2024
34 checks passed
@ihnorton ihnorton deleted the ss/vcpkg-pin-vs-toolset branch March 1, 2024 19:32
Shelnutt2 added a commit that referenced this pull request Mar 3, 2024
This is a continuation of #1906 and enables using Ninja for the Azure pipelines with windows builds also.
Shelnutt2 added a commit that referenced this pull request Mar 3, 2024
This is a continuation of #1906 and enables using Ninja for the Azure pipelines with windows builds also.
Shelnutt2 added a commit that referenced this pull request Mar 3, 2024
This is a continuation of #1906 and enables using Ninja for the Azure pipelines with windows builds also.
Shelnutt2 added a commit that referenced this pull request Mar 3, 2024
This is a continuation of #1906 and enables using Ninja for the Azure pipelines with windows builds also.
Shelnutt2 added a commit that referenced this pull request Mar 3, 2024
This is a continuation of #1906 and enables using Ninja for the Azure pipelines with windows builds also.
kounelisagis pushed a commit that referenced this pull request Mar 4, 2024
…1906)

* Use Ninja in Windows CI and explicitly set the VS toolset version.

* Fix daily test CI.

* Add vcpkg binary caching.

* Pass `-A` in CMake only if specified by an environment variable.

---------

Co-authored-by: Seth Shelnutt <seth@tiledb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants