Fix Filestore unable to read sizes smaller than offset #1907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #39340: Python filestore unable to read sizes smaller than offset. |
ihnorton
requested changes
Mar 1, 2024
kounelisagis
deleted the
agis/sc-39340/python-filestore-unable-to-read-sizes-smaller-than-offset
branch
kounelisagis
added a commit
that referenced
this pull request
Mar 4, 2024
* Fix filestore unable to read sizes smaller than offset * add test for filestore using small buffer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
Filestoreclass, in theread()method this linesize = max(size - offset, 0)does not cover the case of trying to read a size that is smaller than the offset. Consider a 4 byte file. If we want to read the last byte (offset 3, size 1) this check sets the size to 0 incorrectly.Changing it to
size = min(size, len(self) - offset)ensures that we read either the specified size or the remaining length of the file store starting from the offset, whichever is smaller.