rewrite test to be compatible with R < 4.1.0 #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #10691: Adjust new test for R < 4.1.0. |
ihnorton
approved these changes
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new test for the 'piped' query used
|>which is a (very clever) parser extension turning, say,penguins |> summary()into the callsummary(penguins)internally (as wrappingdeparse(substitute(...))around an expression shows). This meaning the pipe is clean and free of side-effects which is nice. It also means it needs the R 4.1.0 or later parser which is less ideal.This PR rewrites the test to the functionally equivalent older style, which is tested. We cannot condition in a test file on R 4.1.0 as the whole file would be parsed first :-/ I looked into other tricks from the test runner setup but nothing really good suggests itself so rewriting may be the way forward.