For domain info cast int64 to double if overflowing #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #14995: Cast-not-error on overflow dimension. |
ihnorton
approved these changes
Feb 24, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
uint64_tone can create domain bounds larger than what R can represent. So far we have savely errored but that blocks e.g. the schema display of the MTA demo. An alternative is to (only in the overflow case) cast todoubleinstead which, while lossy in values beyond the max for the (signed or unsigned) integer types offers greater range.The change has not shown any side effects in testing so far but may merit another discussion.
Marking this as draft for now.Upon further reflection, this is a net-improvement and ready for review, and I'd argue, merging.