Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support group construction with optional config #535

Merged
merged 4 commits into from Apr 4, 2023

Conversation

eddelbuettel
Copy link
Member

This PR adds support for opening a TileDB group object with a config object (as made possible by release 2.15.1).

This of interest to the SOMA project (where group reads still go through the tiledb-r package) as groups can now be queried directly reflecting a configuration option.

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #27289: Support group constructor with config.

@@ -1,6 +1,6 @@
Package: tiledb
Type: Package
Version: 0.19.0.2
Version: 0.19.0.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.19.1 or do i misunderstand?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is on purpose. Releases of the form 'a.b.c' go to CRAN.

Releases of the form 'a.b.c.d' do not and signal pre-release status. But as binaries are built e.g. by r-universe it is useful to separate these out. Folks have been doing this since the dawn of time, and this is unaffected by "someone" more recently suggsting / imposing that 'd' start at 9000. It doesn't. All we need are monotonically increasing sequences that some people like yours truly still start at 1.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And if and when we cut releases that is usually a PR in and by itself. CRAN keeps an eye on how many releases one does so I cannot shoot them over there as quickly and as frequently as we can access PyPi. Such is life.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ thank you! :)

Copy link
Member

@aaronwolen aaronwolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eddelbuettel eddelbuettel merged commit 5e6bec9 into master Apr 4, 2023
10 checks passed
@eddelbuettel eddelbuettel deleted the de/sc-27289/group_ctor_with_config branch April 4, 2023 21:58
@eddelbuettel eddelbuettel mentioned this pull request Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants