Minor interface completion at R level allowing nullable for char vec #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #27381: Minor interface extension. |
awenocur
approved these changes
Apr 6, 2023
johnkerl
reviewed
Apr 6, 2023
| stopifnot(`Argument 'sizeoffset' must be numeric` = is.numeric(sizeoffsets), | ||
| `Argument 'sizedata' must be numeric` = is.numeric(sizedata)) | ||
| bufptr <- libtiledb_query_buffer_var_char_alloc_direct(sizeoffsets, sizedata) | ||
| bufptr <- libtiledb_query_buffer_var_char_alloc_direct(sizeoffsets, sizedata, nullable) |
There was a problem hiding this comment.
maybe add a unit-test case to cover the nullable=FALSE and nullable=TRUE cases in this code change?
There was a problem hiding this comment.
I have some pending work around arrow support where that may fit in.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The allocator for variable cell sized character buffers received a new parameter at the C++ level that we at time time did not carry over to the R interface. This PR completes that and offers a new variable (with default) at the R level.
No new code. One Rd file from a recent PR got updated in the
roxygen2run.