Additional minor memory (and test) refactoring #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddelbuettel
requested review from
ihnorton,
aaronwolen,
johnkerl,
awenocur and
mojaveazure
|
This pull request has been linked to Shortcut Story #36872: Additional care for memory checks in the context of arrow. |
awenocur
reviewed
Nov 10, 2023
awenocur
approved these changes
Nov 10, 2023
Also nix one spurious newline thanks to @awencour
eddelbuettel
deleted the
de/sc-36872/additional_memory_test_refactoring
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to ensure we remain on the good side of CRAN with respect to valgrind testing. We do now a small fixed set of 216 bytes being 'lost definitely' when the AWS SDK initializes, this was may be unavoidable. We saw in some tests that a
char*holding the arrow format string was not recovered, this PR addresses this.A somewhat less tractable problem is that R at shutdown and in its garbage collection does not guarentee it will visit all remaining external pointers. So we can observer different test behavior just by moving test blocks in a file, or to a different. And when we started to separate test files so they test in isolation .. we got back to square one because running all may again lead to false positives. So the only viable strategy is to be more careful about which tests run where. This PR keeps the test surface maximal at CI but smaller in other places like CRAN where some arrow related tests may be skipped.
SC 36872