Correct treatment of ncells=NA for non-character columns #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddelbuettel
requested review from
ihnorton,
aaronwolen,
awenocur,
nickvigilante and
KiterLuc
|
This pull request has been linked to Shortcut Story #43170: Using |
awenocur
approved these changes
Mar 14, 2024
eddelbuettel
force-pushed
the
de/sc-43170/attr_na_cells
branch
from
a2cf224
to
35c4466
Compare
|
I left a last-second thinko in for a check on |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nickvigilante noticed that
ncells=NAmishaves in attributes settings for non-character columns ... and a bit of inspection reveals that its treatment was only done in character columns.This is now fixed, and the parameter setting checks at the main R interface have been beefed up too.