Skip to content

Commit

Permalink
Datatype for domain must be serialized for backwards client compatibi…
Browse files Browse the repository at this point in the history
…lity (#3343)

The domain_from_capnp was changed to no longer deserialize the type
field, but for backwards compatibility we need to continue to set it in
the domain_to_capnp.
  • Loading branch information
Shelnutt2 committed Jul 6, 2022
1 parent 3210625 commit 2d57ae8
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions tiledb/sm/serialization/array_schema.cc
Expand Up @@ -537,6 +537,9 @@ Status domain_to_capnp(
return LOG_STATUS(
Status_SerializationError("Error serializing domain; domain is null."));

// The type must be serialized for backwards compatibility with pre
// TileDB 2.10 clients
domainBuilder->setType(datatype_str(domain->dimension_ptr(0)->type()));
domainBuilder->setTileOrder(layout_str(domain->tile_order()));
domainBuilder->setCellOrder(layout_str(domain->cell_order()));

Expand Down

0 comments on commit 2d57ae8

Please sign in to comment.