address comment from @KiterLuc, fix hdfs failing build

TileDB-Inc · Aug 1, 2022 · 3ca4a22 · 3ca4a22
1 parent b41b687
commit 3ca4a22
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/tiledb/common/filesystem/directory_entry.h b/tiledb/common/filesystem/directory_entry.h
@@ -74,6 +74,7 @@ class directory_entry {
    *
    * @param p The path of the entry
    * @param size The size of the filesystem entry
+   * @param is_directory Value indicating if the entry is a dir or not
    */
   directory_entry(const std::string& p, uintmax_t size, bool is_directory)
       : path_(p)

diff --git a/tiledb/sm/filesystem/hdfs_filesystem.cc b/tiledb/sm/filesystem/hdfs_filesystem.cc
@@ -557,9 +557,9 @@ tuple<Status, optional<std::vector<directory_entry>>> HDFS::ls_with_sizes(
       path = std::string("hdfs://") + path;
     }
     if (fileList[i].mKind == kObjectKindDirectory) {
-      entries.emplace_back(path, 0);
+      entries.emplace_back(path, 0, true);
     } else {
-      entries.emplace_back(path, fileList[i].mSize);
+      entries.emplace_back(path, fileList[i].mSize, false);
     }
   }
   libhdfs_->hdfsFreeFileInfo(fileList, numEntries);