Skip to content

Commit

Permalink
Do not load group metadata when getting it from REST.
Browse files Browse the repository at this point in the history
This was introduced in #4760 where the client tries to load the group metadata when serializing the group metadata request to REST, which causes an infinite loop. The fix reverts to the correct behavior, where we don't try to load the metadata when serializing it from the client.

---
TYPE: BUG
DESC: Do not load group metadata when getting it from REST.
  • Loading branch information
KiterLuc committed Mar 21, 2024
1 parent 8ea85dc commit d25698c
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion tiledb/sm/serialization/group.cc
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@ Status group_metadata_to_capnp(
auto config_builder = group_metadata_builder->initConfig();
RETURN_NOT_OK(config_to_capnp(group->config(), &config_builder));

auto metadata = group->metadata();
Metadata* metadata = load ? group->metadata() : group->unsafe_metadata();

if (metadata->num()) {
auto metadata_builder = group_metadata_builder->initMetadata();
RETURN_NOT_OK(metadata_to_capnp(metadata, &metadata_builder));
Expand Down

0 comments on commit d25698c

Please sign in to comment.