Fix S3 build on Windows; enable S3 build w/out test #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests time out running against minio on azure, for unclear reasons. Several of the dense tests run for 11+ minutes, and the compression tests take 30-60s each. Move tiledb-install to build step
|
Hello @ihnorton, |
|
@cngzhnp it was not caught by the tests/CI, so no worries. Thanks again for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the S3 build on Windows, which was broken due to header reordering in #1463, which created a conflict with a
Windows.hdefinition ofGetMessage->GetMessageA(x-ref solution in aws/aws-sdk-cpp#402).The breakage was not noticed on CI because we do not currently run a build with S3 enabled on Windows, due to the S3 tests timing out when running against minio on Windows. I've verified that minio is running on CI, with a python script that queries the minio
liveandreadypages (ensures status 200). CI logs also indicate that a number of tests requiring S3 do pass (tests which would fail without minio running).Locally, the tests finish successfully in a few minutes on my Windows laptop. I'm still unclear on the reason for the slowdown on azure.
For now, to catch future S3-related build issues, this PR enables
TILEDB_S3for the windows builds, but disables the S3 compiler definition before building the tests, which causes the tests to run in the local configuration.