Expand accepted windows URIs to support UNC paths #2237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NC paths can be used.
|
This pull request has been linked to Clubhouse Story #6445: file:// uri checking too restrictive. |
|
Apart from testing I've done, @ihnorton has experimentally looked at this functionality and sees it as an improvement. |
dhoke4tdb
changed the title
ihnorton
reviewed
Apr 27, 2021
ihnorton
approved these changes
Apr 27, 2021
joe-maley
reviewed
Apr 27, 2021
test/src/unit-uri.cc
Outdated
| @@ -74,8 +74,12 @@ TEST_CASE("URI: Test file URIs", "[uri]") { | |||
| CHECK(!uri.is_invalid()); | |||
| CHECK(URI::is_file(uri.to_string())); | |||
| CHECK(uri.to_string() == "file:///path"); | |||
| #ifndef _WIN32 | |||
| // note: "file://path" is an accepted URI form on windows for UNC | |||
| // level share viewing,but expected .is_invalid() on *nx. | |||
There was a problem hiding this comment.
Done (and a space added after a comma in same comment.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand accepted windows URIs to allow access to commonly used windows UNC paths.
(Changes made are conditionally specific to _WIN32 so *nix URI processing should not be affected.)
TYPE: BUG
DESC: Expand accepted windows URIs.