Fix buffer arguments in unit-curl.cc #2287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rguments to write_header_callback. Specifically, it declares that it has a buffer size that it hasn't allocated. This triggers an ASAN violation. Changed a loop declaration to match the sign of its limit.
joe-maley
approved these changes
May 24, 2021
|
@eric-hughes-tiledb this is in a draft state, is it ready to merge? |
|
It's ready. I had been waiting for CI to finish. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test "CURL: Test curl's header parsing callback" is passing invalid arguments to write_header_callback. Specifically, it declares that it has a buffer size that it hasn't allocated. This triggers an ASAN violation.
TYPE: BUG
DESC: Fix buffer arguments in unit-curl.cc