Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate *_with_key APIs, Part 2 #2308

Merged
merged 1 commit into from
Jun 7, 2021
Merged

Deprecate *_with_key APIs, Part 2 #2308

merged 1 commit into from
Jun 7, 2021

Conversation

bekadavis9
Copy link
Contributor

TYPE: DEPRECATION
DESC: Deprecate all *_with_key APIs.

@bekadavis9 bekadavis9 force-pushed the rd/deprecate_with_key_2 branch 4 times, most recently from bfb14ab to a58ba04 Compare June 1, 2021 20:36
Copy link
Contributor

@joe-maley joe-maley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one misc comment, otherwise LGTM

tiledb/sm/fragment/fragment_info.cc Show resolved Hide resolved
@joe-maley joe-maley merged commit 3b5128a into dev Jun 7, 2021
@Shelnutt2 Shelnutt2 deleted the rd/deprecate_with_key_2 branch June 8, 2021 10:53
Copy link
Member

@stavrospapadopoulos stavrospapadopoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a full pass. Looks good, great work @bekadavis9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants