Refactor get/set buffer APIs #2315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-maley
reviewed
Jun 3, 2021
bekadavis9
force-pushed
the
rd/refactor_buffer_apis
branch
from
b391ef7
to
cedbfe3
Compare
bekadavis9
force-pushed
the
rd/refactor_buffer_apis
branch
11 times, most recently
from
dae477e
to
9421261
Compare
KiterLuc
reviewed
Jun 12, 2021
bekadavis9
force-pushed
the
rd/refactor_buffer_apis
branch
3 times, most recently
from
c08313e
to
e242e92
Compare
stavrospapadopoulos
requested changes
Jun 14, 2021
bekadavis9
force-pushed
the
rd/refactor_buffer_apis
branch
from
e242e92
to
db2c0b1
Compare
bekadavis9
force-pushed
the
rd/refactor_buffer_apis
branch
from
db2c0b1
to
da0ef29
Compare
Shelnutt2
approved these changes
Jun 15, 2021
|
@bekadavis9 this is blocking some other refactors so lets get this checked in. As an immediate followup can you refactor the C++ api to remove all use of the deprecated functions and to introduce new getters/setters than match the new functionality? |
stavrospapadopoulos
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: C_API
DESC: Refactoring [get/set]_buffer APIs