Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to use bzip2 1.0.8 on windows #2332

Merged
merged 6 commits into from Jun 9, 2021
Merged

Conversation

dhoke4tdb
Copy link
Contributor

@dhoke4tdb dhoke4tdb commented Jun 8, 2021

Update bzip2 in windows build to 1.0.8


TYPE: IMPROVEMENT
DESC: Update bzip2 in windows build to 1.0.8

@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #6922: Update TileDB bzip2 super build version (windows).

@dhoke4tdb dhoke4tdb marked this pull request as ready for review June 9, 2021 10:11
@dhoke4tdb
Copy link
Contributor Author

@d-hoke you can store the cmake file in cmake/inputs/patches. We put other local patches there to keep them in the repo.

Done.

@Shelnutt2 Shelnutt2 merged commit ce22d00 into dev Jun 9, 2021
@Shelnutt2 Shelnutt2 deleted the dlh/ch6922-update-bzip2-windows branch June 9, 2021 14:51
github-actions bot pushed a commit that referenced this pull request Jun 9, 2021
* Changes to use bzip2 1.0.8 on windows

* remove path added unnecessarily

* Change fetch url to github permalink plus ?raw=true, -L added for curl to follow redirects necessary to retrieve desired final object

* Place tiledb provided CMakeLists.txt in cmake/inputs/patches/ep_bzip2 and patch into externals/src/ep_bzip2 from there

* Correct copy source path for CMakeLists.txt

* Use cmake macro to reference cmake command rather than direct name
Shelnutt2 pushed a commit that referenced this pull request Jun 9, 2021
* Changes to use bzip2 1.0.8 on windows

* remove path added unnecessarily

* Change fetch url to github permalink plus ?raw=true, -L added for curl to follow redirects necessary to retrieve desired final object

* Place tiledb provided CMakeLists.txt in cmake/inputs/patches/ep_bzip2 and patch into externals/src/ep_bzip2 from there

* Correct copy source path for CMakeLists.txt

* Use cmake macro to reference cmake command rather than direct name

Co-authored-by: dhoke4tdb <78012908+dhoke4tdb@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants