Add better support for cross compilation for OSX #2354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Clubhouse Story #8069: Test cross compilation for osx arm64. |
Shelnutt2
force-pushed
the
sethshelnutt/ch8069/test-cross-compilation-for-osx-arm64
branch
from
0e155dc
to
4b57793
Compare
Shelnutt2
deleted the
sethshelnutt/ch8069/test-cross-compilation-for-osx-arm64
branch
Shelnutt2
restored the
sethshelnutt/ch8069/test-cross-compilation-for-osx-arm64
branch
Shelnutt2
deleted the
sethshelnutt/ch8069/test-cross-compilation-for-osx-arm64
branch
github-actions bot
pushed a commit
that referenced
this pull request
Jun 15, 2021
* Add support CMAKE_OSX_ARCHITECTURES for superbuild * Update openssl configure command for OSX cross compilation * Adjust bzip2 to support MacOS cross compilation * Support CURL cross compilation for MacOS * GCS MacOS cross-compilation tweaks * AWSSDK needs CMAKE_OSX_SYSROOT and CMAKE_OSX_DEPLOYMENT_TARGET for cross compilation
Shelnutt2
added a commit
that referenced
this pull request
Jun 15, 2021
* Add support CMAKE_OSX_ARCHITECTURES for superbuild * Update openssl configure command for OSX cross compilation * Adjust bzip2 to support MacOS cross compilation * Support CURL cross compilation for MacOS * GCS MacOS cross-compilation tweaks * AWSSDK needs CMAKE_OSX_SYSROOT and CMAKE_OSX_DEPLOYMENT_TARGET for cross compilation Co-authored-by: Seth Shelnutt <seth@tiledb.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjusts the super build in order to support cross compilation for OSX. This has been tested for compiling x86_64 from arm64. Only GCS is not supported and this is due to abseil/abseil-cpp#970 blocking the build by using the host instead of target for setting flags. Once abseil/abseil-cpp#970 is solved GCS should work based on the patches included in this PR.
Enable cross compilation using the
CMAKE_OSX_ARCHITECTURESflag. Currently we do not support a universal lib.-DCMAKE_OSX_ARCHITECTURES="arm64"or-DCMAKE_OSX_ARCHITECTURES="x86_64"I plan to squash on merge, this was left in separate commits for ease of review.
TYPE: IMPROVEMENT
DESC: Add support for cross compilation on OSX in superbuild