Initial read refactor #2374
Merged
Initial read refactor #2374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Clubhouse Story #8173: Initial read refactor. |
KiterLuc
force-pushed
the
lr/initial-read-refactor/ch8173
branch
8 times, most recently
from
e1b5a58
to
aae0590
Compare
KiterLuc
force-pushed
the
lr/initial-read-refactor/ch8173
branch
from
aae0590
to
da34b43
Compare
stavrospapadopoulos
approved these changes
Jun 23, 2021
KiterLuc
force-pushed
the
lr/initial-read-refactor/ch8173
branch
from
da34b43
to
196abb6
Compare
Shelnutt2
reviewed
Jun 24, 2021
KiterLuc
force-pushed
the
lr/initial-read-refactor/ch8173
branch
from
196abb6
to
c690518
Compare
Shelnutt2
approved these changes
Jun 24, 2021
This initial refactor for the readers prepares for the creation of all new reader classes. To minimize duplicate code, the code for settings and getting buffers, layout, subarray, config and query condition is moved to the query. It also creates a new interface, IQueryStrategy, which all readers and writers will implement and creates a basic class hierarchy for the strategies. Finally, it creates the reader or writer dynamically when the query is submitted as a IQueryStrategy. --- TYPE: IMPROVEMENT DESC: Initial read refactor
KiterLuc
force-pushed
the
lr/initial-read-refactor/ch8173
branch
from
c690518
to
a929a9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This initial refactor for the readers prepares for the creation of all
new reader classes. To minimize duplicate code, the code for settings
and getting buffers, layout, subarray, config and query condition is
moved to the query. It also creates a new interface, IQueryStrategy,
which all readers and writers will implement and creates a basic class
hierarchy for the strategies. Finally, it creates the reader or writer
dynamically when the query is submitted as a IQueryStrategy.
TYPE: IMPROVEMENT
DESC: Initial read refactor