Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing test that randomly fails because of an uninitialized buffer. #2386

Merged
merged 1 commit into from
Jun 24, 2021

Conversation

KiterLuc
Copy link
Contributor


TYPE: BUG
DESC: Fixing test failure because of an uninitialized buffer.

---
TYPE: BUG
DESC: Fixing test failure because of an uninitialized buffer.
Copy link
Contributor

@eric-hughes-tiledb eric-hughes-tiledb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

A quick grep through the test sources showed 99 more instances of uninitialized char[n]. Some of them are output buffers, which are unlikely to be problematic, but I'm guessing there's more of this lurking.

@KiterLuc
Copy link
Contributor Author

LGTM

A quick grep through the test sources showed 99 more instances of uninitialized char[n]. Some of them are output buffers, which are unlikely to be problematic, but I'm guessing there's more of this lurking.

I'll file a ticket for this.

@Shelnutt2 Shelnutt2 merged commit f9e0629 into dev Jun 24, 2021
@Shelnutt2 Shelnutt2 deleted the lr/unit-capi-array-key-fix branch June 24, 2021 12:16
@github-actions
Copy link
Contributor

The backport to release-2.3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-2.3 release-2.3
# Navigate to the new working tree
cd .worktrees/backport-release-2.3
# Create a new branch
git switch --create backport-2386-to-release-2.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 f9e06292dfe97df110c19acde723b7d1abfd46c2
# Push it to GitHub
git push --set-upstream origin backport-2386-to-release-2.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-2.3

Then, create a pull request where the base branch is release-2.3 and the compare/head branch is backport-2386-to-release-2.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants