Remove selective unfiltering. #2410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Clubhouse Story #8874: Remove selective unfiltering. |
KiterLuc
force-pushed
the
lr/remove-selective-unfiltering/ch8874
branch
2 times, most recently
from
1d19672
to
720674d
Compare
KiterLuc
force-pushed
the
lr/remove-selective-unfiltering/ch8874
branch
from
720674d
to
d5ffd4d
Compare
There was a problem hiding this comment.
This looks good, but will we have backward compatibility issues? cc @Shelnutt2
| RETURN_NOT_OK( | ||
| output->init_var_size(buffer_addressing, std::move(chunk_sizes))); | ||
| RETURN_NOT_OK(output->init_var_size( | ||
| ChunkedBuffer::BufferAddressing::CONTIGUOUS, std::move(chunk_sizes))); |
There was a problem hiding this comment.
Making a note that we now need to clean up ChunkedBuffer as we don't need two different addressing types - they should all be CONTIGUOUS.
There was a problem hiding this comment.
As discussed, I will filed a follow up item for this for next sprint.
stavrospapadopoulos
approved these changes
Jul 24, 2021
KiterLuc
force-pushed
the
lr/remove-selective-unfiltering/ch8874
branch
from
d5ffd4d
to
9f71d2d
Compare
KiterLuc
force-pushed
the
lr/remove-selective-unfiltering/ch8874
branch
from
9f71d2d
to
c592d0b
Compare
From what we know about our customer's use case, they either will read the full array where this gains nothing (and actually this affects the performance negatively because of the added code complexity), or very targeted ones, for which the gains would be very small, unless the tile capacity/extent is unusually large if the users have a poorly configured array. Also, this will allow us to implement compression codec for video and imaging, which won't work with selective unfiltering. --- TYPE: IMPROVEMENT DESC: Remove selective unfiltering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From what we know about our customer's use case, they either will do the full array where this gains nothing (and actually this affects the performance negatively because of the added code complexity), or very targeted ones, for which the gains would be very small, unless the tile capacity/extent is unusually large if the users have a poorly configured array.
Also, this will allow us to implement compression codec for video and imaging, which won't work with selective unfiltering.
TYPE: IMPROVEMENT
DESC: Remove selective unfiltering.