Sparse global order reader: getting rid of the result cell slab copy. #2411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Clubhouse Story #8332: Read refactor: create basic sparse global order reader.. |
| to_copy.emplace_back(tile, it->start_, num_cells); | ||
| copy_end_.first++; | ||
| copy_end_.second = it->start_ + num_cells; | ||
| break; |
There was a problem hiding this comment.
The previous code checked num_cells in the while condition to break when there is no more room to copy, which wasn't accurate since is could also go below 0. I removed the num_cells condition and added the break.
| // Count number of elements actually copied. | ||
| uint64_t cells_copied = 0; | ||
| for (auto rcs : copied) { | ||
| cells_copied += rcs.length_; | ||
| for (uint64_t i = 0; i < copy_end_.first - 1; i++) { |
There was a problem hiding this comment.
Is copy_end_.first - 1 correct or should it be copy_end_.first?
There was a problem hiding this comment.
This line is correct because of cells_copied += copy_end_.second; below the for loop.
This gets rid of the need for a copy of the result cell slabs by keeping and index of where to end the copy operations in ReaderBase. Also noticed the context caches were only used to store cell slab partitions so moved the code to generate those to simple functions. --- TYPE: IMPROVEMENT DESC: Sparse global order reader: no more result cell slab copy.
KiterLuc
force-pushed
the
lr/sparse-global-order-followup/ch8332
branch
from
c9670cc
to
cbc7c13
Compare
stavrospapadopoulos
approved these changes
Jul 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of the need for a copy of the result cell slabs by keeping
and index of where to end the copy operations in ReaderBase.
Also noticed the context caches were only used to store cell slab
partitions so moved the code to generate those to simple functions.
TYPE: IMPROVEMENT
DESC: Sparse global order reader: no more result cell slab copy.