Sparse global order reader: initial memory budget improvements. #2413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Clubhouse Story #8912: Sparse Global Order Reader: Initial memory budget improvements.. |
dhoke4tdb
reviewed
Jul 21, 2021
dhoke4tdb
reviewed
Jul 21, 2021
KiterLuc
force-pushed
the
lr/sp-global-order-reader-memory-improvements/ch8912
branch
from
5b10f51
to
f05cd18
Compare
Add memory management to Fragment Metadata for rtrees and tile offsets loading. A budget cap is set on the array by the reader, when we reach it, it fails the operations. Also keep track of how much data is currently used for future memory budget calculations. Freeing rtrees and tile overlap after computing relevant tiles if a subarray is set. Move away from using a bitset to determine the next tiles to load and using a list of tile ranges instead. This is better since for most of our use cases when having a subarray, the number of tiles is low. --- TYPE: IMPROVEMENT DESC: Sparse global order reader: initial memory budget improvements.
KiterLuc
force-pushed
the
lr/sp-global-order-reader-memory-improvements/ch8912
branch
from
f05cd18
to
60f19ef
Compare
stavrospapadopoulos
deleted the
lr/sp-global-order-reader-memory-improvements/ch8912
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add memory management to Fragment Metadata for rtrees and tile offsets
loading. A budget cap is set on the array by the reader, when we reach
it, it fails the operations. Also keep track of how much data is
currently used for future memory budget calculations.
Freeing rtrees and tile overlap after computing relevant tiles if a
subarray is set.
Move away from using a bitset to determine the next tiles to load and
using a list of tile ranges instead. This is better since for most of
our use cases when having a subarray, the number of tiles is low.
TYPE: IMPROVEMENT
DESC: Sparse global order reader: initial memory budget improvements.