Upgrade to blosc-1.21.0 #2422
Upgrade to blosc-1.21.0 #2422
Conversation
|
This PR supersedes #2246. It's the same code, but with the sanitizer changes in CMake reverted. It might have reused the previous PR, but starting afresh was much less trouble with version control. Can delete the branch in the other PR when this one merges. |
|
@nguyenv as a low-medium priority can you build this branch in the python ecosystem and validate there is no errors/warnings with all the various compiler setups used for wheels? |
external/blosc/CMakeLists.txt
Outdated
| ${SOURCE_DIR}/src/shuffle-generic.c | ||
| ${SOURCE_DIR}/src/bitshuffle-stub.c | ||
| ) | ||
| try_compile(AVX2_DETECTED ${CMAKE_CURRENT_BINARY_DIR} ${SOURCE_DIR}/cmake/detect-avx2.c) |
There was a problem hiding this comment.
These try_compiles are not working currently. I'll check it more this week.
Yes, I am currently working on this. It might take a bit because we are running into issues on Windows with the file path length on CMake. |
|
https://github.com/TileDB-Inc/TileDB-Py/actions/runs/1095516017 All checks pass when building with TileDB-Py. There are warnings, but I'm sure if they are related to the changes on this PR. |
Shelnutt2
force-pushed
the
eh/v2-upgrade-to-blosc-1.21.0
branch
from
6a8374f
to
3b6273f
Compare
|
The latest commit makes sure the cmake AVX2 check runs and pulls in the |
|
@gspowley can you rebase this branch to fix the doc failure? |
gspowley
force-pushed
the
eh/v2-upgrade-to-blosc-1.21.0
branch
from
25fc0e7
to
b41d8c5
Compare
Shelnutt2
force-pushed
the
eh/v2-upgrade-to-blosc-1.21.0
branch
from
b41d8c5
to
4a2ec55
Compare
Shelnutt2
force-pushed
the
eh/v2-upgrade-to-blosc-1.21.0
branch
from
4a2ec55
to
c7d2df3
Compare
* Upgrade to blosc-1.21.0 * update cmake avx2 check and blosc Co-authored-by: George Powley <george.powley@gmail.com>
* Upgrade to blosc-1.21.0 * update cmake avx2 check and blosc Co-authored-by: George Powley <george.powley@gmail.com> Co-authored-by: eric-hughes-tiledb <82400964+eric-hughes-tiledb@users.noreply.github.com> Co-authored-by: George Powley <george.powley@gmail.com>
Blosc had a defect with a duplicate synbol
_xgetbv()on recent versions of clang; it was fixed in their release 1.20.0. This PR upgrades to the current release 1.21.0.Unfortunately, a simple upgrade was not feasible. We had been using files from 1.14.x, insofar as I can determine; the actual version does not seem to have been documented. The files we were using were altered from the originals, and altered in ways that did not make transferring a patch forward to the new version reliable. Furthermore, there had been significant work upstream in the interim. Thus this PR differs significantly in details from what came before, though not at all in terms of scope. Modifications outside of blosc were confined to changing the name of a single
#includefile.TYPE: BUG
DESC: upgrade to blosc 1.21.0 from 1.14.x