Sparse global order reader: respect memory budget. #2425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Clubhouse Story #8652: Refactored readers: Respect memory budget.. |
KiterLuc
force-pushed
the
lr/sparse-global-order-reader-memory/ch8652
branch
2 times, most recently
from
58035bd
to
6735601
Compare
stavrospapadopoulos
approved these changes
Aug 3, 2021
| const std::string Config::SM_MEM_SPARSE_GLOBAL_ORDER_RATIO_QUERY_CONDITION = | ||
| "0.25"; | ||
| const std::string Config::SM_MEM_SPARSE_GLOBAL_ORDER_RATIO_TILE_RANGES = "0.1"; | ||
| const std::string Config::SM_MEM_SPARSE_GLOBAL_ORDER_RATIO_ARRAY_DATA = "0.1"; |
There was a problem hiding this comment.
By "array data", do you mean "attribute data"? If so, perhaps name this (and all related configs) to *_ATTR_DATA?
There was a problem hiding this comment.
I'll keep this one as is, it also includes footers for the fragments.
- Added memory management for query condition and copy attributes ops. - Added configuration parameters for memory budget management. - Cleaning up result tiles not used in result cell slab merging. - Bug fixes to how we load/cleanup result tiles. --- TYPE: IMPROVEMENT DESC: Respect memory budget for sparse global order reader.
KiterLuc
force-pushed
the
lr/sparse-global-order-reader-memory/ch8652
branch
from
6735601
to
528092a
Compare
stavrospapadopoulos
deleted the
lr/sparse-global-order-reader-memory/ch8652
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: IMPROVEMENT
DESC: Respect memory budget for sparse global order reader.