Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some helper log functions #2454

Conversation

Shelnutt2
Copy link
Member

@Shelnutt2 Shelnutt2 commented Aug 21, 2021

These are convenience functions to take strings and stringstreams to make logging easier.


TYPE: IMPROVEMENT
DESC: Add logger internals for `std::string` and `std::stringstream` for developer convenience

@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #9811: Add logging support for char* and stringstream.

tiledb/common/logger.cc Show resolved Hide resolved
@Shelnutt2 Shelnutt2 force-pushed the sethshelnutt/ch9811/add-logging-support-for-char-and-stringstream branch from 7d27c35 to 82178c9 Compare August 24, 2021 19:37
These are convenience functions to take strings and stringstreams to
make logging easier.
@Shelnutt2 Shelnutt2 force-pushed the sethshelnutt/ch9811/add-logging-support-for-char-and-stringstream branch from 82178c9 to 384324a Compare August 26, 2021 12:12
@Shelnutt2 Shelnutt2 merged commit 1a6a833 into dev Aug 26, 2021
@Shelnutt2 Shelnutt2 deleted the sethshelnutt/ch9811/add-logging-support-for-char-and-stringstream branch August 26, 2021 15:08
github-actions bot pushed a commit that referenced this pull request Aug 26, 2021
These are convenience functions to take strings and stringstreams to
make logging easier.
Shelnutt2 added a commit that referenced this pull request Aug 26, 2021
These are convenience functions to take strings and stringstreams to
make logging easier.

Co-authored-by: Seth Shelnutt <seth@tiledb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants