Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored readers: serialization. #2458

Merged
merged 1 commit into from
Sep 6, 2021

Conversation

KiterLuc
Copy link
Contributor

Adding serialization support for the refactored sparse readers. This
should also support resuming interrupted queries by recreating result
tiles from the result cell slab.


TYPE: IMPROVEMENT
DESC: Refactored readers: serialization.

@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #8651: Refactored readers: Serialization.

Copy link
Member

@Shelnutt2 Shelnutt2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already mentioned to @KiterLuc but you can't renumber cap'n proto class members. This breaks compatibility.

@KiterLuc KiterLuc force-pushed the lr/refactored-readers-serialization/ch8651 branch 2 times, most recently from c369a70 to 203b4dc Compare August 23, 2021 15:27
tiledb/sm/serialization/query.cc Outdated Show resolved Hide resolved
tiledb/sm/serialization/query.cc Show resolved Hide resolved
@KiterLuc KiterLuc force-pushed the lr/refactored-readers-serialization/ch8651 branch from 203b4dc to 15e1907 Compare August 27, 2021 15:02
Adding serialization support for the refactored sparse readers. This
should also support resuming interrupted queries by recreating result
tiles from the result cell slab.

---
TYPE: IMPROVEMENT
DESC: Refactored readers: serialization.
@Shelnutt2 Shelnutt2 force-pushed the lr/refactored-readers-serialization/ch8651 branch from 15e1907 to ea5e0ba Compare September 6, 2021 11:31
@Shelnutt2 Shelnutt2 merged commit 44f7f18 into dev Sep 6, 2021
@Shelnutt2 Shelnutt2 deleted the lr/refactored-readers-serialization/ch8651 branch September 6, 2021 14:52
github-actions bot pushed a commit that referenced this pull request Sep 6, 2021
Adding serialization support for the refactored sparse readers. This
should also support resuming interrupted queries by recreating result
tiles from the result cell slab.

---
TYPE: IMPROVEMENT
DESC: Refactored readers: serialization.
Shelnutt2 pushed a commit that referenced this pull request Sep 6, 2021
Adding serialization support for the refactored sparse readers. This
should also support resuming interrupted queries by recreating result
tiles from the result cell slab.

---
TYPE: IMPROVEMENT
DESC: Refactored readers: serialization.

Co-authored-by: KiterLuc <67824247+KiterLuc@users.noreply.github.com>
bekadavis9 pushed a commit that referenced this pull request Oct 13, 2021
Adding serialization support for the refactored sparse readers. This
should also support resuming interrupted queries by recreating result
tiles from the result cell slab.

---
TYPE: IMPROVEMENT
DESC: Refactored readers: serialization.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants