-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored readers: serialization. #2458
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request has been linked to Clubhouse Story #8651: Refactored readers: Serialization. |
Shelnutt2
requested changes
Aug 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already mentioned to @KiterLuc but you can't renumber cap'n proto class members. This breaks compatibility.
KiterLuc
force-pushed
the
lr/refactored-readers-serialization/ch8651
branch
2 times, most recently
from
August 23, 2021 15:27
c369a70
to
203b4dc
Compare
Shelnutt2
reviewed
Aug 23, 2021
KiterLuc
force-pushed
the
lr/refactored-readers-serialization/ch8651
branch
from
August 27, 2021 15:02
203b4dc
to
15e1907
Compare
Adding serialization support for the refactored sparse readers. This should also support resuming interrupted queries by recreating result tiles from the result cell slab. --- TYPE: IMPROVEMENT DESC: Refactored readers: serialization.
Shelnutt2
force-pushed
the
lr/refactored-readers-serialization/ch8651
branch
from
September 6, 2021 11:31
15e1907
to
ea5e0ba
Compare
Shelnutt2
approved these changes
Sep 6, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Sep 6, 2021
Adding serialization support for the refactored sparse readers. This should also support resuming interrupted queries by recreating result tiles from the result cell slab. --- TYPE: IMPROVEMENT DESC: Refactored readers: serialization.
Shelnutt2
pushed a commit
that referenced
this pull request
Sep 6, 2021
Adding serialization support for the refactored sparse readers. This should also support resuming interrupted queries by recreating result tiles from the result cell slab. --- TYPE: IMPROVEMENT DESC: Refactored readers: serialization. Co-authored-by: KiterLuc <67824247+KiterLuc@users.noreply.github.com>
bekadavis9
pushed a commit
that referenced
this pull request
Oct 13, 2021
Adding serialization support for the refactored sparse readers. This should also support resuming interrupted queries by recreating result tiles from the result cell slab. --- TYPE: IMPROVEMENT DESC: Refactored readers: serialization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding serialization support for the refactored sparse readers. This
should also support resuming interrupted queries by recreating result
tiles from the result cell slab.
TYPE: IMPROVEMENT
DESC: Refactored readers: serialization.