Add api for getting array schema of a fragment #2468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Clubhouse Story #9809: Add c/cpp api for getting array schema of a fragment. |
Shelnutt2
requested changes
Aug 26, 2021
| } | ||
|
|
||
| EncryptionKey encryption_key; | ||
| RETURN_NOT_OK(storage_manager_->load_array_schema_from_uri( |
There was a problem hiding this comment.
There is a deficiency here in that we'll be loading the schema for every fragment without any caching. I realize we don't have the openarray object here so we can't use the normal schema map. Lets open a a story for a future improvement here but it doesn't block this PR.
Shelnutt2
approved these changes
Aug 26, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Aug 27, 2021
* add api for getting array schema of a fragment * delete array_schema pointer when error is caught
Shelnutt2
pushed a commit
that referenced
this pull request
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds c and cpp api functions for getting the array schema of a fragment from fragment info object. We store array schema name in the meta data of each fragment. Now we can get the array schema in capi by the tiledb_fragment_info_get_array_schema function. Also a member function array_schema is added to FragmentInfo class in cpp-api.
TYPE: FEATURE
DESC: Add c and cpp api functions for getting the array schema of a fragment
TYPE: C_API
DESC: Add
tiledb_fragment_info_get_array_schemafunctions for getting the array schema of a fragmentTYPE: CPP_API
DESC: Add
FragmentInfo::array_schemafunctions for getting the array schema of a fragment