Allow null data pointers for writes. #2481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- TYPE: IMPROVEMENT DESC: Allow null data pointers for writes.
|
This pull request has been linked to Clubhouse Story #10151: Allow passing nullptr for data buffer if size is zero. |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 6, 2021
As a minor follow up to #2476 we expand the empty attribute writes to allow the data buffer to be null. This is useful for C++ users who might be using `std::vector` for their underlying data buffer where the vector's `std::vector::data()` will return `nullptr` when the vector is empty. --- TYPE: IMPROVEMENT DESC: Allow null data pointers for writes.
Shelnutt2
pushed a commit
that referenced
this pull request
Sep 7, 2021
As a minor follow up to #2476 we expand the empty attribute writes to allow the data buffer to be null. This is useful for C++ users who might be using `std::vector` for their underlying data buffer where the vector's `std::vector::data()` will return `nullptr` when the vector is empty. --- TYPE: IMPROVEMENT DESC: Allow null data pointers for writes. Co-authored-by: KiterLuc <67824247+KiterLuc@users.noreply.github.com>
bekadavis9
pushed a commit
that referenced
this pull request
Oct 13, 2021
As a minor follow up to #2476 we expand the empty attribute writes to allow the data buffer to be null. This is useful for C++ users who might be using `std::vector` for their underlying data buffer where the vector's `std::vector::data()` will return `nullptr` when the vector is empty. --- TYPE: IMPROVEMENT DESC: Allow null data pointers for writes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a minor follow up to #2476 we expand the empty attribute writes to allow the data buffer to be null. This is useful for C++ users who might be using
std::vectorfor their underlying data buffer where the vector'sstd::vector::data()will returnnullptrwhen the vector is empty.TYPE: IMPROVEMENT
DESC: Allow null data pointers for writes.