Wrap some C API functions with exception handlers. #2650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #11442: All c-api functions should use try/catch function body. |
|
Supersedes #2603, which passed over into git-hell by mistake. |
|
Merged with |
ihnorton
approved these changes
Mar 2, 2022
eric-hughes-tiledb
force-pushed
the
eh/sc-11442/all-c-api-functions-should-use-try-catch
branch
from
d23be16
to
360e617
Compare
…those in the section "ENUMS TO/FROM STR". - Changed namespace for defining API implementation functions before wrapping. - Change Status::Error to Status_Error - Add section documentation in tiledb.cc
ihnorton
force-pushed
the
eh/sc-11442/all-c-api-functions-should-use-try-catch
branch
from
ece2cec
to
4505fe5
Compare
ihnorton
deleted the
eh/sc-11442/all-c-api-functions-should-use-try-catch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap some C API functions with exception handlers. The functions are those in the section "ENUMS TO/FROM STR".
TYPE: IMPROVEMENT
DESC: Wrap some C API functions with exception handlers.