revert changes needed for windows build with azure #2656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So confused, saw problem on GA CI, reproduced similar locally, now GA CI in other PRs seem to be succeeding withOUT this change, very confused... To be reopened if still needed... |
|
Reopening - while the catastrophic build failures in CI have not occurred again, the warnings reported in the associated story are still occurring, and reinstating these changes eliminates those link warnings. |
|
@ihnorton - please review (reopened), thanks. |
ihnorton
approved these changes
Dec 13, 2021
| @@ -94,6 +94,10 @@ if (NOT AZURESDK_FOUND) | |||
| endif() | |||
|
|
|||
| if (WIN32) | |||
| if(MSVC) | |||
| set(CXXFLAGS_DEF " -I${TILEDB_EP_INSTALL_PREFIX}/include /Dazure_storage_lite_EXPORTS /DCURL_STATICLIB=1 ${CMAKE_CXX_FLAGS}") | |||
There was a problem hiding this comment.
In theory the only thing that should make a difference here is /DCURL_STATICLIB=1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
restore lost cmake code necessary for clean build on windows with -EnableAzure
TYPE: BUG
DESC: restore lost cmake code necessary for clean build on windows with -EnableAzure