Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query condition should use fragment's array schema #2698

Conversation

Shelnutt2
Copy link
Member

With schema evolution each fragment now carries a reference to its array schema. This is the schema that should be used when looping over the tile to apply query condition. This ensures that the schema matches the tile.


TYPE: BUG
DESC: Use fragment array schema for applying query condition to account for schema evolution

With schema evolution each fragment now carries a reference to its array
schema. This is the schema that should be used when looping over the
tile to apply query condition. This ensures that the schema matches the
tile.
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #12647: Query condition apply should use fragment array schema.

@Shelnutt2 Shelnutt2 merged commit 596aad4 into dev Dec 6, 2021
@Shelnutt2 Shelnutt2 deleted the sethshelnutt/sc-12647/query-condition-apply-should-use-fragment branch December 6, 2021 17:28
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2021

The backport to release-2.5 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-2.5 release-2.5
# Navigate to the new working tree
cd .worktrees/backport-release-2.5
# Create a new branch
git switch --create backport-2698-to-release-2.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 596aad41d1468608256cc7b51a792be40889c851
# Push it to GitHub
git push --set-upstream origin backport-2698-to-release-2.5
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-2.5

Then, create a pull request where the base branch is release-2.5 and the compare/head branch is backport-2698-to-release-2.5.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2021

The backport to release-2.6 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-2.6 release-2.6
# Navigate to the new working tree
cd .worktrees/backport-release-2.6
# Create a new branch
git switch --create backport-2698-to-release-2.6
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 596aad41d1468608256cc7b51a792be40889c851
# Push it to GitHub
git push --set-upstream origin backport-2698-to-release-2.6
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-2.6

Then, create a pull request where the base branch is release-2.6 and the compare/head branch is backport-2698-to-release-2.6.

github-actions bot pushed a commit that referenced this pull request Dec 15, 2021
With schema evolution each fragment now carries a reference to its array
schema. This is the schema that should be used when looping over the
tile to apply query condition. This ensures that the schema matches the
tile.
Shelnutt2 added a commit that referenced this pull request Dec 15, 2021
With schema evolution each fragment now carries a reference to its array
schema. This is the schema that should be used when looping over the
tile to apply query condition. This ensures that the schema matches the
tile.

Co-authored-by: Seth Shelnutt <seth@tiledb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants