Moving coord_string from returning a std::string to std::string_view. #2704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The coord_string function is used in a lot of performance critical paths. Moving it to return a string_view as none of these paths benefit from making a copy of the value. --- TYPE: IMPROVEMENT DESC: Moving coord_string from returning a std::string to std::string_view.
KiterLuc
force-pushed
the
lr/coord-string-fix
branch
from
97c1c7e
to
de69660
Compare
KiterLuc
changed the title
stavrospapadopoulos
approved these changes
Dec 7, 2021
Shelnutt2
approved these changes
Dec 7, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Dec 7, 2021
…#2704) The coord_string function is used in a lot of performance critical paths. Moving it to return a string_view as none of these paths benefit from making a copy of the value. --- TYPE: IMPROVEMENT DESC: Moving coord_string from returning a std::string to std::string_view.
Shelnutt2
pushed a commit
that referenced
this pull request
Dec 9, 2021
…#2704) (#2707) The coord_string function is used in a lot of performance critical paths. Moving it to return a string_view as none of these paths benefit from making a copy of the value. --- TYPE: IMPROVEMENT DESC: Moving coord_string from returning a std::string to std::string_view. Co-authored-by: KiterLuc <67824247+KiterLuc@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The coord_string function is used in a lot of performance critical paths.
Moving it to return a basic_string_view as none of these paths benefit
from making a copy of the value.
TYPE: IMPROVEMENT
DESC: Moving coord_string from returning a std::string to std::basic_string_view.