Store shared_ptr for Attribute in ArraySchema #2887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #14362: Store shared_ptr for Attribute in ArraySchema. |
bekadavis9
force-pushed
the
rd/array_schema_attribute_shared_ptr
branch
from
118abe2
to
ecd048b
Compare
bekadavis9
force-pushed
the
rd/array_schema_attribute_shared_ptr
branch
from
16e7dd7
to
1cff864
Compare
bekadavis9
force-pushed
the
rd/array_schema_attribute_shared_ptr
branch
from
1cff864
to
5d3e022
Compare
eric-hughes-tiledb
requested changes
Feb 21, 2022
Shelnutt2
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step in smart pointer conversion for memory management. The ArraySchema's Attribute pointer has been changed to a
tdb_shared_ptr. [ch14362]TYPE: IMPROVEMENT
DESC: ArraySchema's Attribute smart pointer conversion