Sparse rindex readers: fixing query resume on TileDB cloud. #2900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #14777: Incomplete query loops forever with serialization. |
There are two types of incompletes on TileDB Cloud. One where the user's buffers are not full, but the server side buffers are and one where the user side buffers are full. In the first case, the query is 'kept alive' with it's current state. In the second the query is recreated on the server and all state is lost. This fixes an issue in the second case where the all ranges tile overlap gets recomputed when the query is resumed. In this case, the computation needs to take into account the tile index deserialized from the client. --- TYPE: IMPROVEMENT DESC: Sparse rindex readers: fixing query resume on TileDB cloud.
KiterLuc
force-pushed
the
lr/tiledb-cloud-resume-fix/ch14777
branch
from
8e3425d
to
07089ed
Compare
Shelnutt2
approved these changes
Feb 23, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Feb 23, 2022
There are two types of incompletes on TileDB Cloud. One where the user's buffers are not full, but the server side buffers are and one where the user side buffers are full. In the first case, the query is 'kept alive' with it's current state. In the second the query is recreated on the server and all state is lost. This fixes an issue in the second case where the all ranges tile overlap gets recomputed when the query is resumed. In this case, the computation needs to take into account the tile index deserialized from the client. --- TYPE: IMPROVEMENT DESC: Sparse rindex readers: fixing query resume on TileDB cloud.
github-actions bot
pushed a commit
that referenced
this pull request
Feb 23, 2022
There are two types of incompletes on TileDB Cloud. One where the user's buffers are not full, but the server side buffers are and one where the user side buffers are full. In the first case, the query is 'kept alive' with it's current state. In the second the query is recreated on the server and all state is lost. This fixes an issue in the second case where the all ranges tile overlap gets recomputed when the query is resumed. In this case, the computation needs to take into account the tile index deserialized from the client. --- TYPE: IMPROVEMENT DESC: Sparse rindex readers: fixing query resume on TileDB cloud.
Shelnutt2
pushed a commit
that referenced
this pull request
Feb 23, 2022
…2904) There are two types of incompletes on TileDB Cloud. One where the user's buffers are not full, but the server side buffers are and one where the user side buffers are full. In the first case, the query is 'kept alive' with it's current state. In the second the query is recreated on the server and all state is lost. This fixes an issue in the second case where the all ranges tile overlap gets recomputed when the query is resumed. In this case, the computation needs to take into account the tile index deserialized from the client. --- TYPE: IMPROVEMENT DESC: Sparse rindex readers: fixing query resume on TileDB cloud. Co-authored-by: KiterLuc <67824247+KiterLuc@users.noreply.github.com>
Shelnutt2
pushed a commit
that referenced
this pull request
Feb 23, 2022
…2903) There are two types of incompletes on TileDB Cloud. One where the user's buffers are not full, but the server side buffers are and one where the user side buffers are full. In the first case, the query is 'kept alive' with it's current state. In the second the query is recreated on the server and all state is lost. This fixes an issue in the second case where the all ranges tile overlap gets recomputed when the query is resumed. In this case, the computation needs to take into account the tile index deserialized from the client. --- TYPE: IMPROVEMENT DESC: Sparse rindex readers: fixing query resume on TileDB cloud. Co-authored-by: KiterLuc <67824247+KiterLuc@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two types of incompletes on TileDB Cloud. One where the user's
buffers are not full, but the server side buffers are and one where the
user side buffers are full. In the first case, the query is 'kept alive'
with it's current state. In the second the query is recreated on the
server and all state is lost. This fixes an issue in the second case
where the all ranges tile overlap gets recomputed when the query is
resumed. In this case, the computation needs to take into account the
tile index deserialized from the client.
TYPE: IMPROVEMENT
DESC: Sparse rindex readers: fixing query resume on TileDB cloud.