Remove common.h from cpp_api/arrow_io_impl.h
#2915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/TileDB-Inc/TileDB-Py/runs/5334851540 This builds successfully against TileDB-Py now. One of the unit tests is failing which is a separate issue that seems to be coming from the new |
eric-hughes-tiledb
approved these changes
Feb 25, 2022
There was a problem hiding this comment.
This reverses a change that ended up in #2622 that I made in error. I thought I had taken out all the changes I had in draft with files in this directory, but apparently I missed this one.
LGTM
|
(FWIW also permits me to build again. My bad for not spotting that three-line fix yesterday eve. Nicely done.) |
Shelnutt2
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for TileDB-Inc/TileDB-Py#928.
TYPE: BUG
DESC: Remove
common.hfromarrow_io_impl.h