Don't call generate_uri in ArraySchema accessors #2928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #15238: generate_uri shouldn't be called in accessors. |
Shelnutt2
force-pushed
the
sethshelnutt/sc-15238/generate-uri-shouldn-t-be-called-in-accessors
branch
from
63953f4
to
d2a7f71
Compare
Shelnutt2
force-pushed
the
sethshelnutt/sc-15238/generate-uri-shouldn-t-be-called-in-accessors
branch
from
d2a7f71
to
9380761
Compare
stavrospapadopoulos
approved these changes
Mar 2, 2022
This adjusts how and where we generate the array schema URI/name so we can avoid any mutation in the accessors of ArraySchema such as `name`.
Shelnutt2
force-pushed
the
sethshelnutt/sc-15238/generate-uri-shouldn-t-be-called-in-accessors
branch
from
9380761
to
3fe6ac1
Compare
Shelnutt2
deleted the
sethshelnutt/sc-15238/generate-uri-shouldn-t-be-called-in-accessors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjusts how and where we generate the array schema URI/name so we can avoid any mutation in the accessors of
ArraySchemasuch asname.TYPE: IMPROVEMENT
DESC: Avoid calling
generate_uriinArraySchemaaccessors