Integrate RLE for var-length string dimensions #2938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #13310: Do not store chunk metadata inline with chunk. |
ypatia
force-pushed
the
yt/ch13310/enable_rle_for_string_dimensions
branch
3 times, most recently
from
4ec9459
to
f5198f6
Compare
ypatia
force-pushed
the
yt/ch13310/enable_rle_for_string_dimensions
branch
from
9b47790
to
8517270
Compare
Shelnutt2
reviewed
Mar 10, 2022
ypatia
force-pushed
the
yt/ch13310/enable_rle_for_string_dimensions
branch
2 times, most recently
from
066a2d9
to
fa99212
Compare
ypatia
force-pushed
the
yt/ch13310/enable_rle_for_string_dimensions
branch
from
fa99212
to
486495b
Compare
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-2.8 release-2.8
# Navigate to the new working tree
cd .worktrees/backport-release-2.8
# Create a new branch
git switch --create backport-2938-to-release-2.8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 023cb536012048b2a7f6a3a14066862e55a9aaef
# Push it to GitHub
git push --set-upstream origin backport-2938-to-release-2.8
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-2.8Then, create a pull request where the |
Shelnutt2
pushed a commit
that referenced
this pull request
Mar 16, 2022
* Integrate RLE for var-length string dimensions * Fix windows warning * Fix dates in headers * Various correctness fixes * Fix backwards compatibility issues * Add basic test for string attributes and fix filter UTs * Fix merge issues
Shelnutt2
added a commit
that referenced
this pull request
Mar 17, 2022
* Integrate RLE for var-length string dimensions * Fix windows warning * Fix dates in headers * Various correctness fixes * Fix backwards compatibility issues * Add basic test for string attributes and fix filter UTs * Fix merge issues Co-authored-by: Ypatia Tsavliri <ypatia@tiledb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates the recently introduced RLE algorithms for string compression/decompression to TileDB filter pipeline using the, again, recently introduced Tile-level filtering/unfiltering.
A few improvements will come in following PRs:
Limitations: When RLE is used for string dimensions, we currently require that it's the only filter applied.
In the future this limitation could be relaxed, but some limitation will still be in place to make sure RLE can get applied to the string representation of data so that it makes sense.
TYPE: FEATURE
DESC: RLE compression support for var-length string dimensions