Global order writer: fixing multi writes for var size attributes. #2963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing multiple writes, the global order writer saves the var offets it is at per attributes. This fixes the case where a user would write less than one tile more than once, the offset would get reset when it should not. It also fixes an index issue where a partially filled last tile from a previous write got completed on a subsequent write. --- TYPE: IMPROVEMENT DESC: Global order writer: fixing multi writes for var size attributes.
|
This pull request has been linked to Shortcut Story #15672: Writer issue ingesting VCF data on latest dev.. |
KiterLuc
commented
Mar 14, 2022
| } else { | ||
| for (uint64_t i = 0; i < cell_num_to_write; ++cell_idx, ++i) { | ||
| if (coord_dups.find(cell_idx) == coord_dups.end()) { | ||
| if (cell_num_to_write != 0) { |
There was a problem hiding this comment.
The diff after this is statement is incorrect, the code below has not changed until my next comment.
KiterLuc
commented
Mar 14, 2022
|
|
||
| (*tiles)[tile_idx + 1].final_size(last_var_offset); | ||
| (*tiles)[tile_idx + 1].final_size(last_var_offset); |
There was a problem hiding this comment.
After this comment the diff is correct.
gspowley
approved these changes
Mar 14, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Mar 16, 2022
) When doing multiple writes, the global order writer saves the var offets it is at per attributes. This fixes the case where a user would write less than one tile more than once, the offset would get reset when it should not. It also fixes an index issue where a partially filled last tile from a previous write got completed on a subsequent write. --- TYPE: IMPROVEMENT DESC: Global order writer: fixing multi writes for var size attributes.
Shelnutt2
pushed a commit
that referenced
this pull request
Mar 16, 2022
) (#2972) When doing multiple writes, the global order writer saves the var offets it is at per attributes. This fixes the case where a user would write less than one tile more than once, the offset would get reset when it should not. It also fixes an index issue where a partially filled last tile from a previous write got completed on a subsequent write. --- TYPE: IMPROVEMENT DESC: Global order writer: fixing multi writes for var size attributes. Co-authored-by: KiterLuc <67824247+KiterLuc@users.noreply.github.com>
ypatia
pushed a commit
that referenced
this pull request
Mar 21, 2022
) When doing multiple writes, the global order writer saves the var offets it is at per attributes. This fixes the case where a user would write less than one tile more than once, the offset would get reset when it should not. It also fixes an index issue where a partially filled last tile from a previous write got completed on a subsequent write. --- TYPE: IMPROVEMENT DESC: Global order writer: fixing multi writes for var size attributes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing multiple writes, the global order writer saves the var offets
it is at per attributes. This fixes the case where a user would write
less than one tile more than once, the offset would get reset when it
should not. It also fixes an index issue where a partially filled last
tile from a previous write got completed on a subsequent write.
TYPE: IMPROVEMENT
DESC: Global order writer: fixing multi writes for var size attributes.