Global writes: fixing OOM on write continuation. #2993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
convert_tile_min_max_var_sizes_to_offsets is used to convert a buffer of sizes to offsets. For global writes, the function will be called multiple times on the same buffer so the function should resume from the last tile that was processed. This information is already saved in tile_index_base_ so the fix is trivial. --- TYPE: IMPROVEMENT DESC: Global writes: fixing OOM on write continuation.
|
This pull request has been linked to Shortcut Story #15792: Writer OOM ingesting VCF data. |
Shelnutt2
approved these changes
Mar 19, 2022
gspowley
approved these changes
Mar 19, 2022
KiterLuc
deleted the
lr/convert_tile_min_max_var_sizes_to_offsets-fix/ch15792
branch
github-actions bot
pushed a commit
that referenced
this pull request
Mar 19, 2022
convert_tile_min_max_var_sizes_to_offsets is used to convert a buffer of sizes to offsets. For global writes, the function will be called multiple times on the same buffer so the function should resume from the last tile that was processed. This information is already saved in tile_index_base_ so the fix is trivial. --- TYPE: IMPROVEMENT DESC: Global writes: fixing OOM on write continuation.
github-actions bot
pushed a commit
that referenced
this pull request
Mar 19, 2022
convert_tile_min_max_var_sizes_to_offsets is used to convert a buffer of sizes to offsets. For global writes, the function will be called multiple times on the same buffer so the function should resume from the last tile that was processed. This information is already saved in tile_index_base_ so the fix is trivial. --- TYPE: IMPROVEMENT DESC: Global writes: fixing OOM on write continuation.
ihnorton
pushed a commit
that referenced
this pull request
Mar 21, 2022
convert_tile_min_max_var_sizes_to_offsets is used to convert a buffer of sizes to offsets. For global writes, the function will be called multiple times on the same buffer so the function should resume from the last tile that was processed. This information is already saved in tile_index_base_ so the fix is trivial. --- TYPE: IMPROVEMENT DESC: Global writes: fixing OOM on write continuation.
ihnorton
pushed a commit
that referenced
this pull request
Mar 21, 2022
convert_tile_min_max_var_sizes_to_offsets is used to convert a buffer of sizes to offsets. For global writes, the function will be called multiple times on the same buffer so the function should resume from the last tile that was processed. This information is already saved in tile_index_base_ so the fix is trivial. --- TYPE: IMPROVEMENT DESC: Global writes: fixing OOM on write continuation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
convert_tile_min_max_var_sizes_to_offsets is used to convert a buffer of
sizes to offsets. For global writes, the function will be called
multiple times on the same buffer so the function should resume from the
last tile that was processed. This information is already saved
in tile_index_base_ so the fix is trivial.
TYPE: IMPROVEMENT
DESC: Global writes: fixing OOM on write continuation.