Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error reporting in tiledb_subarray_alloc #3220

Merged
merged 4 commits into from Jun 11, 2022

Conversation

bekadavis9
Copy link
Contributor

Properly catch and report error in tiledb_subarray_alloc


TYPE: IMPROVEMENT
DESC: Fix error reporting in tiledb_subarray_alloc

@bekadavis9 bekadavis9 requested a review from ihnorton May 26, 2022 21:23
@bekadavis9
Copy link
Contributor Author

[sc-17940]

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #17940: Report errors properly in tiledb_subarray_alloc.

tiledb/sm/c_api/tiledb.cc Outdated Show resolved Hide resolved
Copy link
Contributor

@eric-hughes-tiledb eric-hughes-tiledb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Memory leak needs correcting.

tiledb/sm/c_api/tiledb.cc Outdated Show resolved Hide resolved
tiledb/sm/c_api/tiledb.cc Outdated Show resolved Hide resolved
@bekadavis9 bekadavis9 force-pushed the rd/subarray_alloc-error_reporting branch from e3ca8f9 to 571dba0 Compare June 10, 2022 18:25
Copy link
Contributor

@eric-hughes-tiledb eric-hughes-tiledb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But for some redundant code, looks good.

tiledb/sm/c_api/tiledb.cc Outdated Show resolved Hide resolved
@ihnorton ihnorton merged commit 1299d8e into dev Jun 11, 2022
@ihnorton ihnorton deleted the rd/subarray_alloc-error_reporting branch June 11, 2022 00:59
@github-actions
Copy link
Contributor

The backport to release-2.10 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-2.10 release-2.10
# Navigate to the new working tree
cd .worktrees/backport-release-2.10
# Create a new branch
git switch --create backport-3220-to-release-2.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 1299d8e5e032b6f2c769fd5ef476eee1712bdc64
# Push it to GitHub
git push --set-upstream origin backport-3220-to-release-2.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-2.10

Then, create a pull request where the base branch is release-2.10 and the compare/head branch is backport-3220-to-release-2.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants