Enforce version upper bound for reads. Validate open array paths for TILEDB_EXPERIMENTAL #3248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #18231: Implement validation in array open paths for TILEDB_EXPERIMENTAL. |
jp-dark
approved these changes
Jun 17, 2022
|
This looks good to me. We will need to update the CMake so that the object libraries also get the definitions, but that can happen in a separate PR. |
ihnorton
force-pushed
the
rd/experimental_array_open_validation
branch
2 times, most recently
from
3aeaa46
to
18808b1
Compare
ihnorton
force-pushed
the
rd/experimental_array_open_validation
branch
from
18808b1
to
9bdd9b7
Compare
ypatia
reviewed
Jun 22, 2022
ihnorton
reviewed
Jun 22, 2022
jp-dark
requested changes
Jun 22, 2022
…(experimental build only) This PR adds enforcement that the library cannot read from arrays written by a newer version of libtiledb; and will not write to arrays with an older format version _if_ the current build is an experimental build. Co-authored-by: Isaiah Norton <ihnorton@users.noreply.github.com>
ihnorton
force-pushed
the
rd/experimental_array_open_validation
branch
from
ecd1192
to
49dba75
Compare
jp-dark
approved these changes
Jun 23, 2022
ihnorton
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enforce version upper bound for reads. Implement validation in open array paths for TILEDB_EXPERIMENTAL.
TYPE: FEATURE
DESC: Enforce version upper bound for reads. Validate open array paths for TILEDB_EXPERIMENTAL