fix timestamp_no_ms() for 32bit #3292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #18759: timestamp_now_ms() incorrect in 32bit environment. |
tiledb/sm/misc/tdb_time.cc
Outdated
| @@ -44,9 +44,9 @@ namespace tiledb::sm::utils::time { | |||
|
|
|||
| uint64_t timestamp_now_ms() { | |||
| #ifdef _WIN32 | |||
| struct _timeb tb; | |||
| struct __timeb64 tb; | |||
| memset(&tb, 0, sizeof(struct _timeb)); | |||
There was a problem hiding this comment.
If you switch from struct _timeb to struct __timeb64 the memset() may need adjusting too.
eddelbuettel
approved these changes
Jun 21, 2022
ihnorton
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change for 32/64 bit consistency (corrects return of incorrect 32bit values)
(affects rtools40 32bit build)
TYPE: BUG
DESC: fix timestamp_no_ms() for 32bit