Bug Fix: Wrong results when using OR condition with nullable attributes #3308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #18836: Wrong results when using OR condition with nullable attributes. |
KiterLuc
requested changes
Jun 23, 2022
ihnorton
requested review from
DimitrisStaratzis
and removed request for
KiterLuc
|
I confirm it fixes the issue I had in Java. |
ihnorton
reviewed
Jun 24, 2022
KiterLuc
reviewed
Jul 9, 2022
…lekim/sc-18836/wrong-results-when-using-or-condition
KiterLuc
approved these changes
Jul 13, 2022
ihnorton
reviewed
Jul 13, 2022
ihnorton
reviewed
Jul 13, 2022
ihnorton
approved these changes
Jul 14, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Jul 14, 2022
…es (#3308) Fixed the bug on nullable attributes by refactoring the query condition so that nullable attributes are processed at the same time as the cell values. I also wrote test cases that test on complex query conditions with nullable attributes. TYPE:BUG DESC: Bug Fix: Wrong results when using OR condition with nullable attributes
ihnorton
deleted the
abigalekim/sc-18836/wrong-results-when-using-or-condition
branch
ihnorton
pushed a commit
that referenced
this pull request
Jul 14, 2022
…es (#3308) (#3367) Fixed the bug on nullable attributes by refactoring the query condition so that nullable attributes are processed at the same time as the cell values. I also wrote test cases that test on complex query conditions with nullable attributes. TYPE:BUG DESC: Bug Fix: Wrong results when using OR condition with nullable attributes Co-authored-by: Abigale Kim <abigale.kim@tiledb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the bug on nullable attributes by refactoring the query condition so that nullable attributes are processed at the same time as the cell values. I also wrote test cases that test on complex query conditions with nullable attributes.
TYPE:BUG
DESC: Bug Fix: Wrong results when using OR condition with nullable attributes