compute_results_count_sparse_string: using cached ranges properly. #3314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #3263, compute_results_count_sparse_string now caches ranges to do it's computations, so cached_ranges should be used instead of range_indexes. This change fixes one place that still used range_indexes. --- TYPE: IMPROVEMENT DESC: compute_results_count_sparse_string: using cached ranges properly.
|
This pull request has been linked to Shortcut Story #18941: Heap corruption in compute_results_count_string. |
ihnorton
reviewed
Jun 24, 2022
There was a problem hiding this comment.
I confirm that this fixes the issue, but in the existing code, the loop variable to construct the caches is the same as the variable where they are used, so what caused the problem? Are we modifying ranges somewhere else?
i <- range_indexes refers into ranges which may be larger than cached_ranges.
ihnorton
approved these changes
Jun 24, 2022
ihnorton
deleted the
lr/result-count-sparse-string-cached-ranges-fix/ch18941
branch
github-actions bot
pushed a commit
that referenced
this pull request
Jun 24, 2022
…3314) In #3263, compute_results_count_sparse_string now caches ranges to do it's computations, so cached_ranges should be used instead of range_indexes. This change fixes one place that still used range_indexes. --- TYPE: IMPROVEMENT DESC: compute_results_count_sparse_string: using cached ranges properly.
ihnorton
pushed a commit
that referenced
this pull request
Jun 24, 2022
…3314) In #3263, compute_results_count_sparse_string now caches ranges to do it's computations, so cached_ranges should be used instead of range_indexes. This change fixes one place that still used range_indexes. --- TYPE: IMPROVEMENT DESC: compute_results_count_sparse_string: using cached ranges properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3263, compute_results_count_sparse_string now caches ranges to do
it's computations, so cached_ranges should be used instead of
range_indexes. This change fixes one place that still used range_indexes.
TYPE: IMPROVEMENT
DESC: compute_results_count_sparse_string: using cached ranges properly.