Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only update pkg-config private requirements if on Windows #3330

Merged
merged 1 commit into from Jul 6, 2022

Conversation

eddelbuettel
Copy link
Member

The tiledb.pc for for pkg-config currently gets an unconditional private requirements part which breaks its use under Linux. This PR changes this only add the section if on Windows.


TYPE: BUG
DESC: Update pkg-config private requirements on Windows only

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #18993: pkg-config unusuable due to libmagic changes.

Copy link
Contributor

@dhoke4tdb dhoke4tdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine for now.

at the least, static builds on *nix (previously) didn't work, so this may have to be revisited when/if that is addressed.

@ihnorton ihnorton merged commit b2518cf into dev Jul 6, 2022
@ihnorton ihnorton deleted the de/sc-18993/no_private_requirements_in_pkgconfig branch July 6, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants