Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deletes: implement delete strategy. #3337

Merged
merged 10 commits into from Jul 14, 2022
Merged

Deletes: implement delete strategy. #3337

merged 10 commits into from Jul 14, 2022

Conversation

KiterLuc
Copy link
Contributor

@KiterLuc KiterLuc commented Jul 4, 2022

This implements the strategy for delete queries that allow to write the
delete commit to disk.

It also implements a storage manager API to load the deletes from disk,
which will be used by the readers.


TYPE: IMPROVEMENT
DESC: Deletes: implement delete strategy.

@KiterLuc KiterLuc requested review from ypatia and ihnorton July 4, 2022 11:25
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #18971: Deletes: create strategy for deletes..

This implements the strategy for delete queries that allow to write the
delete commit to disk.

It also implements a storage manager API to load the deletes from disk,
which will be used by the readers.

---
TYPE: IMPROVEMENT
DESC: Deletes: implement delete strategy.
@KiterLuc KiterLuc force-pushed the lr/delete-stratefy/ch18971 branch from 4708948 to 3e4193e Compare July 4, 2022 11:45
@KiterLuc KiterLuc force-pushed the lr/delete-stratefy/ch18971 branch 3 times, most recently from e280813 to c8fefc7 Compare July 4, 2022 16:20
@KiterLuc KiterLuc force-pushed the lr/delete-stratefy/ch18971 branch from c8fefc7 to ed28524 Compare July 5, 2022 08:58
test/src/unit-cppapi-deletes.cc Outdated Show resolved Hide resolved
tiledb/sm/query/ast/query_ast.cc Outdated Show resolved Hide resolved
tiledb/sm/query/deletes_and_updates/deletes.cc Outdated Show resolved Hide resolved
tiledb/sm/query/deletes_and_updates/deletes.cc Outdated Show resolved Hide resolved
tiledb/sm/storage_manager/storage_manager.cc Outdated Show resolved Hide resolved
tiledb/sm/c_api/tiledb_enum.h Show resolved Hide resolved
@@ -588,14 +588,17 @@ const int32_t library_version[3] = {
TILEDB_VERSION_MAJOR, TILEDB_VERSION_MINOR, TILEDB_VERSION_PATCH};

/** The TileDB serialization format version number. */
const uint32_t format_version = 15;
const uint32_t format_version = 16;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update format-spec?

@KiterLuc KiterLuc merged commit 8d64b1f into dev Jul 14, 2022
@KiterLuc KiterLuc deleted the lr/delete-stratefy/ch18971 branch July 14, 2022 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants