New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deletes: implement delete strategy. #3337
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request has been linked to Shortcut Story #18971: Deletes: create strategy for deletes.. |
This implements the strategy for delete queries that allow to write the delete commit to disk. It also implements a storage manager API to load the deletes from disk, which will be used by the readers. --- TYPE: IMPROVEMENT DESC: Deletes: implement delete strategy.
KiterLuc
force-pushed
the
lr/delete-stratefy/ch18971
branch
from
July 4, 2022 11:45
4708948
to
3e4193e
Compare
KiterLuc
force-pushed
the
lr/delete-stratefy/ch18971
branch
3 times, most recently
from
July 4, 2022 16:20
e280813
to
c8fefc7
Compare
KiterLuc
force-pushed
the
lr/delete-stratefy/ch18971
branch
from
July 5, 2022 08:58
c8fefc7
to
ed28524
Compare
ypatia
reviewed
Jul 11, 2022
@@ -588,14 +588,17 @@ const int32_t library_version[3] = { | |||
TILEDB_VERSION_MAJOR, TILEDB_VERSION_MINOR, TILEDB_VERSION_PATCH}; | |||
|
|||
/** The TileDB serialization format version number. */ | |||
const uint32_t format_version = 15; | |||
const uint32_t format_version = 16; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update format-spec?
ypatia
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the strategy for delete queries that allow to write the
delete commit to disk.
It also implements a storage manager API to load the deletes from disk,
which will be used by the readers.
TYPE: IMPROVEMENT
DESC: Deletes: implement delete strategy.