Serialization: using same functions to choose strategy than in query. #3352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the query code and serialization code to use the same functions to choose readers which is going to be less error prone than before if there is any updates. --- TYPE: IMPROVEMENT DESC: Serialization: using same functions to choose strategy than in query.
|
This pull request has been linked to Shortcut Story #19265: Create a better centralized way to determine query strategy. |
ihnorton
reviewed
Jul 8, 2022
|
@ihnorton For this review, probably not. But I think we need to have a better solution altogether for config keys... |
ihnorton
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the query code and serialization code to use the same
functions to choose readers which is going to be less error prone than
before if there is any updates.
TYPE: IMPROVEMENT
DESC: Serialization: using same functions to choose strategy than in query.