Lums/sc 18061/combined #3366
Merged
Lums/sc 18061/combined #3366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… verify unit tests.
…ent allocators [skip ci]
|
This pull request has been linked to Shortcut Story #18061: Implement DataBlockAllocator for Core task graph. |
ihnorton
approved these changes
Aug 4, 2022
| /** | ||
| * @todo Use proper checks for preprocessor directives to selectively include | ||
| * test with `std::execution` policy. | ||
| */ | ||
| #if 0 |
There was a problem hiding this comment.
Can we remove this in order to get testing on all platforms?
| * Data chunks will be aligned to page boundaries. | ||
| * Assumed to be 4k. | ||
| * | ||
| * @todo Determine page size at compile-time for the target architecture. |
There was a problem hiding this comment.
(minor aside: I believe this is not arch-specific, at least on linux, with "huge pages" support)
| @@ -70,7 +74,8 @@ class generator { | |||
| template <class Block, class StateMachine> | |||
| class ProducerNode : public Source<Block, StateMachine> { | |||
| using Base = Source<Block, StateMachine>; | |||
| std::atomic<size_t> i_{0}; | |||
| // This causes initialization problems | |||
| // std::atomic<size_t> i_{0}; | |||
There was a problem hiding this comment.
Do we need this for correctness?
| * storage as a `shared_ptr<std::byte>`. | ||
| */ | ||
| using storage_t = std::shared_ptr<std::byte>; | ||
| using span_t = tcb::span<std::byte>; |
There was a problem hiding this comment.
nit: existing code is using span without namespace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes updates (and/or implementations) for sc-18059, sc-18060, and sc-18061. (There was some trouble with rebasing during this PR, so there appear to be many more commits than there actually were -- there are many apparent duplicates.)
The PR includes the following files (omitting CMakeLists.txt and various trivial files):
data_block
├── data_block.cc
├── data_block.h
├── pool_allocator.cc
├── pool_allocator.h
└── test
├── unit_data_block.cc
├── unit_data_block.h
├── unit_pool_allocator.cc
└── unit_pool_allocator.h
Implementation of
DataBlockandDataBlockallocator. The allocator is a simplepool (free list) allocator of fixed-size chunks of bytes. A
DataBlockis acontainer that has a
shared_ptrto a single chunk.ports
├── fsm.cc
├── fsm.h
├── fsm.md
├── policies.h
├── ports.cc
├── ports.h
├── sink_state_machine.svg
├── source_state_machine.svg
└── test
├── helpers.h
├── pseudo_nodes.cc
├── pseudo_nodes.h
├── unit_concurrency.cc
├── unit_concurrency.h
├── unit_fsm.cc
├── unit_fsm.h
├── unit_ports.cc
├── unit_ports.h
├── unit_pseudo_nodes.cc
└── unit_pseudo_nodes.h
Implementation of the
SourceandSinkports, which are the primary data structuresfor transferring data between nodes in the task graph. The transfer is controlled by
a finite state machine (defined in fsm.h and documented in fsm.md). Unit tests
include tests for the state maching, for the ports themselves, and for the use of
ports in a very rudimentary task graph setting. For these latter tests we use "pseudo
nodes", which are also tested. Also included are unit tests to verify that execution
of pseudo nodes does in fact occur concurrently.
utils
├── range_join.cc
├── range_join.h
├── spinlock.cc
├── spinlock.h
└── test
├── unit_range_join.cc
└── unit_spinlock.cc
We needed a few utilities for implementing the classes above. To create single
contiguous views of multiple
DataBlocks we implemented ajoinview, which issimilar to
std::ranges::join_view. In anticipation of future lightweight synchronization needsin scheduling, we also implemented a spin lock (or, really, a spin mutex, which can be
locked with
std::lock_guard, etc.). Also included are unit tests for both.TYPE: FEATURE
DESC: Implementation of
DataBlock,DataBlockallocator,joinview, and updates toSourceandSink.