Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates group serial/deserial to use sizeof only on types #3399

Merged
merged 1 commit into from Aug 2, 2022
Merged

Updates group serial/deserial to use sizeof only on types #3399

merged 1 commit into from Aug 2, 2022

Conversation

jp-dark
Copy link
Contributor

@jp-dark jp-dark commented Jul 29, 2022

Fixes groups to only use sizeof on types instead of variables.

TYPE: BUG
DESC: Prevent possible compiler dependent errors serializing groups

@jp-dark jp-dark requested a review from ihnorton July 29, 2022 18:48
ihnorton
ihnorton approved these changes Aug 2, 2022
View reviewed changes
tiledb/sm/group/group_member_v1.cc Show resolved Hide resolved
@ihnorton ihnorton merged commit eac140e into dev Aug 2, 2022
@ihnorton ihnorton deleted the jpd/fix-group-serialize branch August 2, 2022 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihnorton ihnorton ihnorton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jp-dark @ihnorton